Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-101] Remove dept-devops from CODEOWNERS #44

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

michalchecinski
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-101

📔 Objective

Remove dept-devops from CODEOWNERS.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski requested a review from a team as a code owner June 7, 2024 15:18
Copy link

github-actions bot commented Jun 7, 2024

Logo
Checkmarx One – Scan Summary & Detailsea2b9834-01f7-4276-9093-59838292c66f

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 138 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

@joseph-flinn joseph-flinn added the hold DO NOT MERGE! label Jun 13, 2024
@eliykat
Copy link
Member

eliykat commented Oct 10, 2024

@michalchecinski is this PR still required, or can it be closed?

@michalchecinski michalchecinski removed the hold DO NOT MERGE! label Oct 15, 2024
@michalchecinski
Copy link
Contributor Author

@eliykat It's still required, I just updated it as we resumed work on this issue.

.github/CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Vince Grassia <[email protected]>
@michalchecinski michalchecinski merged commit ffb38b4 into main Oct 18, 2024
7 of 9 checks passed
@michalchecinski michalchecinski deleted the BRE-101-Remove-dept-devops-from-CODEOWNERS branch October 18, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants