Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1266] Review PHP docs #878

Closed
wants to merge 10 commits into from
Closed

[SM-1266] Review PHP docs #878

wants to merge 10 commits into from

Conversation

mzieniukbw
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1266

📔 Objective

Review PHP language docs.
Fixed some of the typos too that prevented the example to work correctly.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mzieniukbw mzieniukbw requested a review from a team July 5, 2024 15:27
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Logo
Checkmarx One – Scan Summary & Details6537ff0d-2e6f-489b-803d-5cf1c51640ac

No New Or Fixed Issues Found

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.98%. Comparing base (7ee604f) to head (4a973df).
Report is 27 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #878   +/-   ##
=======================================
  Coverage   57.98%   57.98%           
=======================================
  Files         197      197           
  Lines       13651    13651           
=======================================
  Hits         7916     7916           
  Misses       5735     5735           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mzieniukbw mzieniukbw requested review from Hinton and dani-garcia July 8, 2024 14:46
languages/php/INSTALL.md Outdated Show resolved Hide resolved
languages/php/src/SecretsClient.php Show resolved Hide resolved
@mzieniukbw mzieniukbw requested a review from Thomas-Avery July 11, 2024 09:55
languages/php/INSTALL.md Outdated Show resolved Hide resolved
@mzieniukbw mzieniukbw requested a review from Thomas-Avery July 12, 2024 09:57
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If @dani-garcia or @Hinton have more context on the original intent of where this should look for the native libs, I'm open to changes.

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns from my side, I think looking for the libs with a relative path makes sense

@mzieniukbw
Copy link
Contributor Author

mzieniukbw commented Sep 18, 2024

Superseded by #1032 and #1036

@mzieniukbw mzieniukbw closed this Sep 18, 2024
@mzieniukbw mzieniukbw deleted the sm/sm-1266-php-docs branch September 18, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants