Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-1939 - Pin actions to main #717

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

vgrassia
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This PR pins the bitwarden/gh-actions/get-keyvault-secrets actions to main.

Code changes

  • .github/workflows/publish-php.yml: Pin all uses of bitwarden/gh-actions/get-keyvault-secrets to main.

Before you submit

  • Please add unit tests where it makes sense to do so

@vgrassia vgrassia self-assigned this Apr 15, 2024
@vgrassia vgrassia requested a review from a team as a code owner April 15, 2024 20:05
@vgrassia vgrassia enabled auto-merge (squash) April 15, 2024 20:07
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details8c173170-d3a8-4ef8-ab65-15061cd33c6e

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /publish-php.yml: 89 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.66%. Comparing base (38b4d25) to head (c4ea0d1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #717   +/-   ##
=======================================
  Coverage   60.66%   60.66%           
=======================================
  Files         173      173           
  Lines       10628    10628           
=======================================
  Hits         6447     6447           
  Misses       4181     4181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgrassia vgrassia merged commit 9c7a1a0 into main Apr 15, 2024
76 checks passed
@vgrassia vgrassia deleted the devops-1939_pin-actions-to-main branch April 15, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants