Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6437] Implement admin password reset logic #631

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Feb 27, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Implement cryptographic logic for admin password reset.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia February 27, 2024 10:09
@bitwarden-bot
Copy link

bitwarden-bot commented Feb 27, 2024

Logo
Checkmarx One – Scan Summary & Detailscdf48410-d080-4e3e-81c6-ac227944bed3

No New Or Fixed Issues Found

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 74.64789% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 59.50%. Comparing base (63b6a9e) to head (0765c94).

Files Patch % Lines
crates/bitwarden-uniffi/src/crypto.rs 0.00% 12 Missing ⚠️
crates/bitwarden/src/mobile/client_crypto.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
+ Coverage   59.40%   59.50%   +0.10%     
==========================================
  Files         171      171              
  Lines       10345    10416      +71     
==========================================
+ Hits         6145     6198      +53     
- Misses       4200     4218      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton merged commit aad7014 into main Feb 27, 2024
58 checks passed
@Hinton Hinton deleted the ps/enroll-admin-password branch February 27, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants