allow empty word separator in passphrases #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
==========================================
- Coverage 59.44% 59.43% -0.01%
==========================================
Files 171 171
Lines 10324 10320 -4
==========================================
- Hits 6137 6134 -3
+ Misses 4187 4186 -1 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
Hinton
approved these changes
Feb 12, 2024
dani-garcia
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
LGTM!
@Hinton The change was merged on the client applications last week too: bitwarden/clients#5473
|
And there's also an open PR in the mobile repo: bitwarden/mobile#2526. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Allow the passphrase word separator to be the empty string
''.This change recently merged in the clients repository.
Code changes