-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-6165] Update bindings with enum names #594
Conversation
No New Or Fixed Issues Found |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
+ Coverage 58.86% 59.44% +0.58%
==========================================
Files 171 171
Lines 10219 10324 +105
==========================================
+ Hits 6015 6137 +122
+ Misses 4204 4187 -17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, generated code matches my local build
Type of change
Objective
Update the generated bindings to use
x-enum-varname
which allows us to generate semantically useful enums instead ofVariant0
.Depends on bitwarden/server#3767
Before you submit