Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6165] Update bindings with enum names #594

Merged
merged 7 commits into from
Feb 9, 2024
Merged

[PM-6165] Update bindings with enum names #594

merged 7 commits into from
Feb 9, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Feb 8, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Update the generated bindings to use x-enum-varname which allows us to generate semantically useful enums instead of Variant0.

Depends on bitwarden/server#3767

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton changed the title Update bindings with enum names [PM-6165] Update bindings with enum names Feb 8, 2024
@bitwarden-bot
Copy link

bitwarden-bot commented Feb 8, 2024

Logo
Checkmarx One – Scan Summary & Details39ea0c43-80ab-41ac-b60c-979adbd4714b

No New Or Fixed Issues Found

@Hinton Hinton requested a review from dani-garcia February 8, 2024 14:40
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (9399346) 58.86% compared to head (7d06640) 59.44%.

Files Patch % Lines
crates/bitwarden/src/admin_console/policy.rs 0.00% 11 Missing ⚠️
crates/bitwarden/src/vault/cipher/cipher.rs 0.00% 6 Missing ⚠️
crates/bitwarden/src/vault/cipher/login.rs 0.00% 6 Missing ⚠️
crates/bitwarden/src/vault/cipher/field.rs 0.00% 4 Missing ⚠️
crates/bitwarden/src/auth/login/mod.rs 0.00% 2 Missing ⚠️
crates/bitwarden/src/vault/send.rs 0.00% 2 Missing ⚠️
crates/bitwarden/src/auth/login/auth_request.rs 0.00% 1 Missing ⚠️
crates/bitwarden/src/auth/register.rs 0.00% 1 Missing ⚠️
crates/bitwarden/src/vault/cipher/secure_note.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   58.86%   59.44%   +0.58%     
==========================================
  Files         171      171              
  Lines       10219    10324     +105     
==========================================
+ Hits         6015     6137     +122     
+ Misses       4204     4187      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dani-garcia
dani-garcia previously approved these changes Feb 8, 2024
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, generated code matches my local build

@Hinton Hinton marked this pull request as ready for review February 9, 2024 08:47
@Hinton Hinton merged commit 6882a20 into main Feb 9, 2024
56 of 57 checks passed
@Hinton Hinton deleted the ps/enum-names branch February 9, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants