[PM-6104] Add locking support to bitwarden-json to improve bindings thread safety #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani-garcia
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
=======================================
Coverage ? 57.79%
=======================================
Files ? 168
Lines ? 9907
Branches ? 0
=======================================
Hits ? 5726
Misses ? 4181
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
Hinton
reviewed
Feb 8, 2024
| @@ -44,41 +45,43 @@ impl Client { | |||
| } | |||
| }; | |||
|
|
|||
| let mut client = self.0.lock().await; | |||
There was a problem hiding this comment.
Bit un-intuitive that we never have to release the lock and it's handled on drop.
There was a problem hiding this comment.
Yeah, most locks in Rust follow that pattern of release on drop, though you can always make an explicit drop(client);
Hinton
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
I've added the lock into bitwarden-json because we already do locking in bitwarden-wasm and this way we can remove it from there.