Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to 1.71 and add CI test #589

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Update MSRV to 1.71 and add CI test #589

merged 5 commits into from
Feb 13, 2024

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Feb 6, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Update MSRV in Cargo.toml and Readme to be up to date with the dependencies that we're using, plus add a test to check that we don't deviate from it.

The dependency causing the bump is env_logger with a MSRV of 1.71 (released July 2023) https://github.com/rust-cli/env_logger/blob/9303b0c0393c33046a791b0a6497b0f03ef1f434/Cargo.toml#L8

The issue seems to also be affecting other crates in the workspace that don't depend on that crate because the MSRV bump is due to some cargo changes regarding dep: features and so it seems to affect the version resolution of the entire workspace.

Note that this required a small change to exporters, apparently older rust versions have trouble disambiguating the csv crate with the csv module.

@dani-garcia dani-garcia marked this pull request as ready for review February 6, 2024 19:07
@dani-garcia dani-garcia requested a review from a team as a code owner February 6, 2024 19:07
@dani-garcia dani-garcia requested a review from Hinton February 6, 2024 19:07
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2290bc8) 59.44% compared to head (79c689d) 59.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage   59.44%   59.44%           
=======================================
  Files         171      171           
  Lines       10324    10324           
=======================================
  Hits         6137     6137           
  Misses       4187     4187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

bitwarden-bot commented Feb 7, 2024

Logo
Checkmarx One – Scan Summary & Details1818f498-9b54-40a2-aab4-b8fc0fce2316

No New Or Fixed Issues Found

Hinton
Hinton previously approved these changes Feb 8, 2024
@Hinton Hinton merged commit 42ca1b0 into main Feb 13, 2024
61 checks passed
@Hinton Hinton deleted the ps/msrv branch February 13, 2024 10:17
@coltonhurst coltonhurst mentioned this pull request Mar 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants