Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-3438] Encrypted export #588

Merged
merged 5 commits into from
Feb 8, 2024
Merged

[PM-3438] Encrypted export #588

merged 5 commits into from
Feb 8, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Feb 6, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Implement encrypted export

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia February 6, 2024 15:40
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (714c2d4) 57.76% compared to head (4efaf5c) 58.58%.
Report is 5 commits behind head on main.

❗ Current head 4efaf5c differs from pull request most recent head 32f9467. Consider uploading reports for the commit 32f9467 to get more accurate results

Files Patch % Lines
crates/bitwarden-exporters/src/encrypted_json.rs 94.76% 10 Missing ⚠️
crates/bitwarden/src/tool/exporters/mod.rs 90.00% 4 Missing ⚠️
crates/bitwarden-crypto/src/keys/pin_key.rs 76.92% 3 Missing ⚠️
crates/bitwarden-exporters/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   57.76%   58.58%   +0.81%     
==========================================
  Files         168      171       +3     
  Lines        9912    10143     +231     
==========================================
+ Hits         5726     5942     +216     
- Misses       4186     4201      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton force-pushed the ps/encrypted-export branch from 747a772 to facce07 Compare February 6, 2024 16:33
@bitwarden-bot
Copy link

bitwarden-bot commented Feb 6, 2024

Logo
Checkmarx One – Scan Summary & Details8f1f053e-9e91-4a9a-bf89-330366d00b52

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 151 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 75 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 68 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 70
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 213
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 146
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 63

dani-garcia
dani-garcia previously approved these changes Feb 8, 2024
crates/bitwarden-crypto/src/keys/pin_key.rs Outdated Show resolved Hide resolved
@Hinton Hinton merged commit aa30b65 into main Feb 8, 2024
41 of 42 checks passed
@Hinton Hinton deleted the ps/encrypted-export branch February 8, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants