-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use non-root user in Docker #571
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
=======================================
Coverage 59.41% 59.41%
=======================================
Files 171 171
Lines 10342 10342
=======================================
Hits 6145 6145
Misses 4197 4197 ☔ View full report in Codecov by Sentry. |
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the BWS_CONFIG_FILE
option 🎉
Type of change
Objective
Use a non-root user in Docker. There doesn't seem to be an agreed upon standard for what to name the non-root user, so I named it app, as I followed the general guidance from this MS blog post.
A
BWS_CONFIG_FILE
environment variable was added tobws
as well to make it easier to avoid guessing where the correct config file dir is if you are unaware of the app user's name (and therefor, their home directory).Code changes
BWS_CONFIG_FILE
environment variable.Before you submit