Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SM owned files to code owners #494

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Add SM owned files to code owners #494

merged 8 commits into from
Jun 28, 2024

Conversation

Thomas-Avery
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Add Secrets Manager owned files to code owners file.

Code changes

  • .github/CODEOWNERS:
    Add Secrets Manager owned files to code owners file.

Before you submit

  • Please add unit tests where it makes sense to do so

@Thomas-Avery Thomas-Avery self-assigned this Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.00%. Comparing base (cdca710) to head (34082ef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage   56.00%   56.00%           
=======================================
  Files         193      193           
  Lines       12607    12607           
=======================================
  Hits         7060     7060           
  Misses       5547     5547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coltonhurst
coltonhurst previously approved these changes Jan 10, 2024
Copy link
Member

@coltonhurst coltonhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed this looks good. Open to thoughts that @Hinton might have.

@Thomas-Avery Thomas-Avery added the hold do not merge, do not approve yet label Jun 20, 2024
@Thomas-Avery Thomas-Avery marked this pull request as draft June 20, 2024 18:18
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Logo
Checkmarx One – Scan Summary & Detailsec8c574b-631d-4aae-a631-dee4cace2156

No New Or Fixed Issues Found

@Thomas-Avery Thomas-Avery marked this pull request as ready for review June 28, 2024 19:42
@Thomas-Avery Thomas-Avery requested a review from coltonhurst June 28, 2024 19:42
@Thomas-Avery Thomas-Avery removed the hold do not merge, do not approve yet label Jun 28, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
@Thomas-Avery Thomas-Avery requested a review from Hinton June 28, 2024 20:17
@Thomas-Avery Thomas-Avery requested a review from a team June 28, 2024 20:18
@Thomas-Avery Thomas-Avery merged commit b375edc into main Jun 28, 2024
104 checks passed
@Thomas-Avery Thomas-Avery deleted the sm/add-sm-owner branch June 28, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants