Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize totp base32 and use no pad #492

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Sanitize totp base32 and use no pad #492

merged 1 commit into from
Jan 10, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 10, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fix difference in our totp handling in the sdk and clients repository.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia January 10, 2024 08:23
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe7bce3) 49.32% compared to head (70b2d5f) 49.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   49.32%   49.34%   +0.01%     
==========================================
  Files         154      154              
  Lines        7371     7373       +2     
==========================================
+ Hits         3636     3638       +2     
  Misses       3735     3735              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton merged commit 339f45e into main Jan 10, 2024
42 checks passed
@Hinton Hinton deleted the ps/totp-base32 branch January 10, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants