Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5346] Implement password strength #489

Merged
merged 7 commits into from
Jan 9, 2024
Merged

[PM-5346] Implement password strength #489

merged 7 commits into from
Jan 9, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 9, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Break up password.rs into a module for clarity. Implement password strength along test cases that are replicated in the clients codebase.

Before you submit

  • Please add unit tests where it makes sense to do so

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (719f7e8) 48.60% compared to head (0b2b432) 49.45%.
Report is 2 commits behind head on main.

❗ Current head 0b2b432 differs from pull request most recent head 1c9c7c7. Consider uploading reports for the commit 1c9c7c7 to get more accurate results

Files Patch % Lines
crates/bitwarden/src/auth/password/validate.rs 92.30% 3 Missing ⚠️
crates/bitwarden/src/auth/password/policy.rs 98.62% 2 Missing ⚠️
crates/bitwarden/src/auth/password/strength.rs 98.59% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   48.60%   49.45%   +0.84%     
==========================================
  Files         152      154       +2     
  Lines        7271     7389     +118     
==========================================
+ Hits         3534     3654     +120     
+ Misses       3737     3735       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton marked this pull request as ready for review January 9, 2024 11:57
@Hinton Hinton changed the title Implement password strength [PM-5346] Implement password strength Jan 9, 2024
@Hinton Hinton requested a review from dani-garcia January 9, 2024 11:58
crates/bitwarden/src/auth/password/strength.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/auth/password/strength.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/auth/password/strength.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/auth/password/strength.rs Outdated Show resolved Hide resolved
@Hinton Hinton requested a review from dani-garcia January 9, 2024 12:40
@Hinton Hinton merged commit 54b6759 into main Jan 9, 2024
40 of 41 checks passed
@Hinton Hinton deleted the ps/password-strength branch January 9, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants