Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating the users fingerprint #474

Merged
merged 7 commits into from
Jan 5, 2024
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 4, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add support for generating the users fingerprint using the private key from EncSettings.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (8dd2e45) 46.29% compared to head (55f2e06) 46.50%.
Report is 1 commits behind head on main.

Files Patch % Lines
crates/bitwarden-uniffi/src/platform/mod.rs 0.00% 16 Missing ⚠️
crates/bitwarden/src/platform/client_platform.rs 0.00% 9 Missing ⚠️
crates/bitwarden-json/src/client.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   46.29%   46.50%   +0.20%     
==========================================
  Files         153      154       +1     
  Lines        7080     7144      +64     
==========================================
+ Hits         3278     3322      +44     
- Misses       3802     3822      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton requested a review from MGibson1 January 4, 2024 16:53
@Hinton Hinton merged commit 68236d3 into main Jan 5, 2024
42 checks passed
@Hinton Hinton deleted the ps/fingerprint branch January 5, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants