Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Swap out our custom python implementation for uniffi generated bindings. This will allow us to get rid of the pyo3 bindings and our hand written python code. Ultimately simplifying our logic.
Remaining work is to refactor
bitwarden-uniffi
with two features to properly exposesecrets
. I believe this effort is worth it, since there are golang and csharp bindgen we can explore utilizing.Uses maturin to generate the wheels.
Currently blocked by PyO3/maturin#1904.
Code changes
Screenshots
Before you submit