Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename service_account_id to access_token_id #405

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Rename service_account_id to access_token_id #405

merged 1 commit into from
Dec 7, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Dec 7, 2023

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Rename service_account_id to access_token_id to better represent the actual data. Since it's not a service account id but rather an access token id.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@Hinton Hinton requested a review from dani-garcia December 7, 2023 16:17
@Hinton Hinton changed the title Change service_account_id to access_token_id Rename service_account_id to access_token_id Dec 7, 2023
@Hinton Hinton enabled auto-merge (squash) December 7, 2023 16:54
@Hinton Hinton merged commit a4bf99b into master Dec 7, 2023
40 checks passed
@Hinton Hinton deleted the ps/access_token_id branch December 7, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hinton @dani-garcia