Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial TOTP implementation #392

Merged
merged 9 commits into from
Dec 4, 2023
Merged

Initial TOTP implementation #392

merged 9 commits into from
Dec 4, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Dec 4, 2023 •
edited
Loading

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Convert the TotpService from clients repository to rust.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@bitwarden-bot
Copy link

bitwarden-bot commented Dec 4, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 655ba9b2-8ad8-49a0-af7e-9527b634c73c

No New Or Fixed Issues Found

@Hinton Hinton marked this pull request as ready for review December 4, 2023 10:05
@Hinton Hinton requested a review from dani-garcia December 4, 2023 11:09
dani-garcia
dani-garcia reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, mostly style things, and some ways to make the derive_otp function infallible

crates/bitwarden/src/vault/totp.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/vault/totp.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/vault/totp.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/vault/totp.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/vault/totp.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/vault/totp.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/vault/totp.rs Outdated Show resolved Hide resolved
dani-garcia
dani-garcia reviewed Dec 4, 2023
View reviewed changes
crates/bitwarden/src/vault/totp.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/vault/totp.rs Outdated Show resolved Hide resolved
@Hinton Hinton merged commit 48aeb58 into master Dec 4, 2023
40 checks passed
@Hinton Hinton deleted the ps/PM-3433 branch December 4, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @bitwarden-bot @dani-garcia