Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort cargo.toml files #344

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Sort cargo.toml files #344

merged 2 commits into from
Nov 23, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Nov 23, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Sort cargo.toml files alphabetically.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@Hinton Hinton requested a review from dani-garcia November 23, 2023 16:45
@bitwarden-bot
Copy link

bitwarden-bot commented Nov 23, 2023

Logo
Checkmarx One – Scan Summary & Details0deb99c5-d05d-4f27-a252-fbd5b91293d8

No New Or Fixed Issues Found

@dani-garcia
Copy link
Member

Do we have a way to add a new dependency at the correct place? Usually I use cargo add -p bitwarden whatever, but that doesn't respect the order afaik.

Did you order them manually or use a specific formatter?

@Hinton
Copy link
Member Author

Hinton commented Nov 23, 2023

I used https://crates.io/crates/cargo-sort cargo sort --grouped --workspace

It seems cargo add respects sorting, so we should be good.

@Hinton Hinton merged commit 94dae37 into master Nov 23, 2023
46 checks passed
@Hinton Hinton deleted the ps/sort-cargo branch November 23, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants