Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reqwest header constants #343

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Use reqwest header constants #343

merged 1 commit into from
Nov 23, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Nov 23, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Use reqwest constants instead of magic strings where possible.

Extracted from #44.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@Hinton Hinton requested a review from dani-garcia November 23, 2023 16:40
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – 2cc291c0-596d-4c6e-8394-f891f04d2cee

No New Or Fixed Issues Found

@Hinton Hinton merged commit 2f04f8c into master Nov 23, 2023
45 checks passed
@Hinton Hinton deleted the ps/reqwest-header branch November 23, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @bitwarden-bot @dani-garcia