[PM-6108] Add support for missing AES decrypt types #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Hinton
changed the title
dani-garcia
force-pushed
the
ps/more-aes-decrypt-support
branch
from
a89e868 to
a76b21b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage ? 58.90%
=======================================
Files ? 171
Lines ? 10211
Branches ? 0
=======================================
Hits ? 6015
Misses ? 4196
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Hinton
requested changes
Feb 8, 2024
Hinton
approved these changes
Feb 8, 2024
Comment on lines
+244
to
+247
| // TODO: SymmetricCryptoKey is designed to handle 32 byte keys only, but this | ||
| // variant uses a 16 byte key This means the key+mac are going to be | ||
| // parsed as a single 32 byte key, at the moment we split it manually | ||
| // When refactoring the key handling, this should be fixed. |
There was a problem hiding this comment.
I created a new one in SDK future: PM-6164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add support for the missing AES decryption types:
AesCbc256_B64andAesCbc128_HmacSha256_B64.Note that
SymmetricCryptoKeyat the moment expects 32 byte keys, and AES128 used 16 byte keys, so the 16byte key+mac get parsed as a single 32byte key. At the moment we just split it by hand, but ultimately we would need to handle this better in a future refactor.