Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude snapshots from the GH artifact cleanup job #321

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Exclude snapshots from the GH artifact cleanup job #321

merged 1 commit into from
Nov 3, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Nov 3, 2023

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

GitHub packages doesn't update the date on snapshots, this caused our cleanup script to cleanup a snapshot version in use.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@Hinton Hinton requested a review from a team as a code owner November 3, 2023 14:43
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – b7b74be9-7ec0-4754-ad60-6be086e97ab4

No New Or Fixed Issues Found

@Hinton Hinton merged commit a19c452 into master Nov 3, 2023
45 checks passed
@Hinton Hinton deleted the ps/cleanup-snapshot branch November 3, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimartin12 mimartin12 mimartin12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @bitwarden-bot @mimartin12