Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a non-zero exit code when no subcommands are supplied #296

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Return a non-zero exit code when no subcommands are supplied #296

merged 2 commits into from
Oct 19, 2023

Conversation

tangowithfoxtrot
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Return a non-zero exit code when no subcommands are supplied. This matches the behavior in many other CLIs (bw, git, ssh, etc.).

Code changes

  • crates/bws/src/main.rs: Exit with a non-zero exit code

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@bitwarden-bot
Copy link

bitwarden-bot commented Oct 19, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 50bca25d-5b0c-4698-8dd6-f671a80e8c04

No New Or Fixed Issues Found

@tangowithfoxtrot tangowithfoxtrot marked this pull request as ready for review October 19, 2023 14:57
dani-garcia
dani-garcia approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

coltonhurst
coltonhurst approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@coltonhurst coltonhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tangowithfoxtrot tangowithfoxtrot merged commit 9ff37c7 into master Oct 19, 2023
45 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the SM-773-bws-no-args-to-stderr branch October 19, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coltonhurst coltonhurst coltonhurst approved these changes

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tangowithfoxtrot @bitwarden-bot @dani-garcia @coltonhurst