[PM-4270] Individual cipher key encryption #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani-garcia
force-pushed
the
ps/pm-4270-cipher-key-encryption
branch
from
96cb9a4 to
dd33b1e
Compare
|
No New Or Fixed Issues Found |
Hinton
reviewed
Nov 2, 2023
| @@ -77,6 +79,8 @@ pub struct CipherView { | |||
| pub folder_id: Option<Uuid>, | |||
| pub collection_ids: Vec<Uuid>, | |||
|
|
|||
| pub key: Option<EncString>, | |||
There was a problem hiding this comment.
Do we want to expose the key in a view?
There was a problem hiding this comment.
If we want to encrypt it back with the same Key, yeah. Though I guess we can generate a new key each time we encrypt a CipherView into a Cipher, if we wanted.
There was a problem hiding this comment.
Makes sense, once the SDK has state we don't have to expose it though and can just look it up internally.
There was a problem hiding this comment.
Should we add a TODO or open a ticket for the future?
Hinton
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Implement individual vault item encryption and encryption. Note that at the moment it will not migrate items that don't have a key when encrypting.