[PM-3434] Password generator

[dani-garcia]

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Implement password generation
The min_ fields were set to bool incorrectly I assume, so I changed them to u8.

At the moment if all the minimums turn out larger than the length, I just expand the length, but that seems wrong. I feel like it would be best to return an error in that case instead of changing any values behind the user, thoughts?

[bitwarden-bot]

Checkmarx One – Scan Summary & Details – 4e45146c-e3f6-4843-83e1-83c34ddc6a7a

No New Or Fixed Issues Found

[Hinton]

This looks good from a quick glance. I think we should try and break up the deterministic portions of the code and unit tests those. Add a few tests ensuring the generated password contains the needed characters.

[audreyality]

At the moment if all the minimums turn out larger than the length, I just expand the length, but that seems wrong. I feel like it would be best to return an error in that case instead of changing any values behind the user, thoughts?

Bitwarden desktop, web, and browser update the minimum password length when the minimum digit value changes. The behavior works as follows:

• When the min digit value is greater than 9, the value is set to 9.
• When the min special character quantity is greater than 9, the control sets its value to 9.
• When the min digit quantity is set, [minimum password length] = [minimum digit quantity] + 2.
• When the min special character quantity is set, if its value is greater than [minimum password length] - [minimum digit quantity], the value is set to the difference between these quantities.
• The absolute minimum password size is 5.

This behavior was just confirmed as appropriate in PM-252, and should be preserved in your implementation.

[audreyality]

• 👍 - for great changes
• ❓ - BLOCKS REVIEW - for questions
• ⚠️ - BLOCKS APPROVAL - for more significant problems or concerns needing attention
• 📝 - for notes or general info
• 💭 - for open-ended inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 - for suggestions / improvements

[audreyality]

Just do what you're going to do.