Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert symmetric crypto keys to use marker traits #256

Closed
wants to merge 1 commit into from

Conversation

MGibson1
Copy link
Member

traits and structs are markers for the purpose of the key

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Work on starting to make usage of crypto keys explicit at compile time

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

traits and structs are markers for the purpose of the key
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details2fb9e101-bc01-4bfe-82d7-ddc451a47dd0

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Heap_Inspection /languages/csharp/BitwardenSdk.cs: 34 Attack Vector
LOW Heap_Inspection /languages/csharp/BitwardenSdk.cs: 27 Attack Vector

@Hinton
Copy link
Member

Hinton commented Jan 11, 2024

After discussion with @MGibson1 we will continue using the new type pattern since it provides the benefit of not exposing the inner implementation. With the tradeoff of needing to duplicate traits on the newtype.

@Hinton Hinton closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants