Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer Maven package at SDK repository #233

Closed
wants to merge 4 commits into from
Closed

Conversation

withinfocus
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Publishes the Maven artifact to the SDK repository vs. the spinoff private one just for that purpose.

Code changes

  • languages/kotlin/sdk/build.gradle: Path change.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@withinfocus withinfocus marked this pull request as ready for review September 13, 2023 21:38
@bitwarden-bot
Copy link

bitwarden-bot commented Sep 13, 2023

Logo
Checkmarx One – Scan Summary & Details17469ea1-a194-44ad-9903-8ddff8fbc18b

No New Or Fixed Issues Found

@withinfocus withinfocus requested a review from Hinton September 13, 2023 21:40
@Hinton
Copy link
Member

Hinton commented Sep 14, 2023

We need to do a few more changes for this to work.

  • Rename sdk to contain mobile or kotlin. Since it's going to collide with the java version.
  • Remove PAT
  • Ideally update snapshot naming to be last-version-snapshot. since snapshots keep all old versions resulting in large sizes. We'll want a way to delete older snapshots.
  • Configure artifacts cleanup for non tagged versions.

@withinfocus withinfocus requested a review from a team as a code owner September 14, 2023 13:15
@withinfocus
Copy link
Contributor Author

We need to do a few more changes for this to work.

  • Rename sdk to contain mobile or kotlin. Since it's going to collide with the java version.

Done.

  • Remove PAT

Not sure why we'd remove the token access as this is needed to publish to Packages.

  • Ideally update snapshot naming to be last-version-snapshot. since snapshots keep all old versions resulting in large sizes. We'll want a way to delete older snapshots.

Pushed a commit that uses non-snapshot versioning for master pushes, otherwise use the version and branch name with a snapshot otherwise. Is this what you're wanting?

  • Configure artifacts cleanup for non tagged versions.

Do we want to automate this across the whole repo?

@withinfocus
Copy link
Contributor Author

@Hinton
Copy link
Member

Hinton commented Sep 14, 2023

Replaced with #235

@Hinton Hinton closed this Sep 14, 2023
@withinfocus
Copy link
Contributor Author

You can always make commits directly to this branch vs. new branch and PR creation.

@withinfocus withinfocus deleted the maven-destination branch September 14, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants