Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cipher notes to be optional #232

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Change cipher notes to be optional #232

merged 1 commit into from
Sep 13, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 13, 2023

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Cipher notes are optional.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@Hinton Hinton requested a review from dani-garcia September 13, 2023 15:56
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – 14235688-e7c7-417b-8a93-1b13e5aa6589

No New Or Fixed Issues Found

@Hinton Hinton merged commit 85893a7 into master Sep 13, 2023
39 checks passed
@Hinton Hinton deleted the ps/notes-optional branch September 13, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @bitwarden-bot @dani-garcia