Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same urls for debug and release #230

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Use the same urls for debug and release #230

merged 2 commits into from
Sep 13, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 13, 2023 •
edited
Loading

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Use the same urls for debug and release to avoid confusion.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@Hinton Hinton requested a review from dani-garcia September 13, 2023 10:03
@Hinton Hinton changed the title We should use the same urls for debug and release since it could othe… We should use the same urls for debug and release Sep 13, 2023
@Hinton Hinton changed the title We should use the same urls for debug and release Use the same urls for debug and release Sep 13, 2023
@bitwarden-bot
Copy link

bitwarden-bot commented Sep 13, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – c93f3f96-f3df-46c8-baec-0600e4f10232

No New Or Fixed Issues Found

@Hinton Hinton mentioned this pull request Sep 13, 2023
Merged
dani-garcia
dani-garcia approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that having separate configs for debug and release is confusing, i've tripped on it a couple of times

@Hinton Hinton enabled auto-merge (squash) September 13, 2023 18:36
@Hinton Hinton merged commit 8cae558 into master Sep 13, 2023
31 checks passed
@Hinton Hinton deleted the ps/change-debut-urls branch September 13, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @bitwarden-bot @dani-garcia