-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SM-874: Fix Python Integration #229
Conversation
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Couple of minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments, otherwise I'd say it looks good
Type of change
Objective
The Python integration is out of date and is not currently working. This PR fixes the Python integration by adding the ability to log in via access token, which is currently the supported way to interact with the Bitwarden Secrets Manager SDK. This PR also adds a
ProjectsClient
tobitwarden_client.py
for easy use, and updates the error handling on Project or Secret deletes in the SDK.Code changes
AccessTokenLoginResponse
struct to be generated so access token auth is available to integrations.schemas
:AccessTokenLoginRequest
AccessTokenLoginResponse
ResponseForAccessTokenLoginResponse
access_token_login
to support authenticating with an access tokenproject_ids
parameter to thecreate
andupdate
functions forSecretsClient
ProjectsClient
class andprojects()
to theBitwardenClient
sys
, etc.)login.py
toexample.py
Before you submit