Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build Rust Cross Platform Upload #1107

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented Oct 1, 2024

📔 Objective

This PR splits the upload artifact step into two, in order to have a single path defined for each action. This makes sure that the artifact folder names are not changed during upload. Test run.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Oct 1, 2024
@vgrassia vgrassia requested a review from a team as a code owner October 1, 2024 17:42
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Logo
Checkmarx One – Scan Summary & Detailsba801af8-8539-481f-903a-22c9100a024d

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.44%. Comparing base (66949af) to head (1c7855c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1107   +/-   ##
=======================================
  Coverage   58.44%   58.44%           
=======================================
  Files         192      192           
  Lines       13528    13528           
=======================================
  Hits         7907     7907           
  Misses       5621     5621           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgrassia vgrassia enabled auto-merge (squash) October 1, 2024 18:12
@vgrassia vgrassia merged commit 8dde05e into main Oct 1, 2024
100 of 106 checks passed
@vgrassia vgrassia deleted the fix-rust-cross-platform-artifact-upload branch October 1, 2024 20:36
@djsmith85 djsmith85 linked an issue Dec 16, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native library (darwin-x86-64/libbitwarden_c.dylib) not found in resource path
2 participants