Update MSRV to 1.72 and add CI test

bitwarden · Feb 6, 2024 · fa7ea24 · fa7ea24
1 parent bf02c3b
commit fa7ea24
Show file tree

Hide file tree

Showing 16 changed files with 36 additions and 15 deletions.
diff --git a/.github/workflows/rust-test.yml b/.github/workflows/rust-test.yml
@@ -77,6 +77,27 @@ jobs:
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
+  msrv:
+    name: Check Rust minimum supported version
+    runs-on: ubuntu-22.04
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+
+      - name: Install rust
+        uses: dtolnay/rust-toolchain@be73d7920c329f220ce78e0234b8f96b7ae60248 # stable
+        with:
+          # Important: When updating this, make sure to update the Readme file
+          # and also the `rust-version` field in all the `Cargo.toml`.
+          toolchain: 1.72.0
+
+      - name: Cache cargo registry
+        uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # v2.7.3
+
+      - name: Test
+        run: cargo check --all-features    
+
   wasm:
     name: WASM
 

diff --git a/crates/bitwarden-c/Cargo.toml b/crates/bitwarden-c/Cargo.toml
@@ -2,7 +2,7 @@
 name = "bitwarden-c"
 version = "0.1.0"
 edition = "2021"
-rust-version = "1.57"
+rust-version = "1.72"
 
 [lib]
 crate-type = ["lib", "staticlib", "cdylib"]

diff --git a/crates/bitwarden-cli/Cargo.toml b/crates/bitwarden-cli/Cargo.toml
@@ -2,7 +2,7 @@
 name = "bitwarden-cli"
 version = "0.1.0"
 edition = "2021"
-rust-version = "1.57"
+rust-version = "1.72"
 
 [dependencies]
 clap = { version = "4.4.18", features = ["derive"] }

diff --git a/crates/bitwarden-crypto/Cargo.toml b/crates/bitwarden-crypto/Cargo.toml
@@ -10,7 +10,7 @@ Internal crate for the bitwarden crate. Do not use.
 """
 keywords = ["bitwarden"]
 edition = "2021"
-rust-version = "1.57"
+rust-version = "1.72"
 
 [features]
 default = []

diff --git a/crates/bitwarden-generators/Cargo.toml b/crates/bitwarden-generators/Cargo.toml
@@ -10,7 +10,7 @@ Internal crate for the bitwarden crate. Do not use.
 """
 keywords = ["bitwarden"]
 edition = "2021"
-rust-version = "1.57"
+rust-version = "1.72"
 
 [features]
 mobile = ["uniffi"] # Mobile-specific features

diff --git a/crates/bitwarden-json/Cargo.toml b/crates/bitwarden-json/Cargo.toml
@@ -11,7 +11,7 @@ JSON bindings for the Bitwarden Secret Manager SDK
 keywords = ["bitwarden", "secrets manager"]
 categories = ["api-bindings"]
 edition = "2021"
-rust-version = "1.57"
+rust-version = "1.72"
 
 [features]
 internal = ["bitwarden/internal"] # Internal testing methods

diff --git a/crates/bitwarden-napi/Cargo.toml b/crates/bitwarden-napi/Cargo.toml
@@ -10,7 +10,7 @@ N-API bindings for the Bitwarden Secrets Manager SDK
 """
 keywords = ["bitwarden", "secrets manager"]
 edition = "2021"
-rust-version = "1.57"
+rust-version = "1.72"
 
 [lib]
 crate-type = ["cdylib", "rlib"]

diff --git a/crates/bitwarden-py/Cargo.toml b/crates/bitwarden-py/Cargo.toml
@@ -2,7 +2,7 @@
 name = "bitwarden-py"
 version = "0.1.0"
 edition = "2021"
-rust-version = "1.57"
+rust-version = "1.72"
 
 [lib]
 name = "bitwarden_py"

diff --git a/crates/bitwarden-uniffi/Cargo.toml b/crates/bitwarden-uniffi/Cargo.toml
@@ -2,7 +2,7 @@
 name = "bitwarden-uniffi"
 version = "0.1.0"
 edition = "2021"
-rust-version = "1.57"
+rust-version = "1.72"
 
 [features]
 docs = ["dep:schemars"] # Docs

diff --git a/crates/bitwarden-wasm/Cargo.toml b/crates/bitwarden-wasm/Cargo.toml
@@ -2,7 +2,7 @@
 name = "bitwarden-wasm"
 version = "0.1.0"
 edition = "2021"
-rust-version = "1.57"
+rust-version = "1.72"
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/crates/bitwarden/Cargo.toml b/crates/bitwarden/Cargo.toml
@@ -10,7 +10,7 @@ Bitwarden Secrets Manager SDK
 """
 keywords = ["bitwarden", "secrets-manager"]
 edition = "2021"
-rust-version = "1.57"
+rust-version = "1.72"
 
 [features]
 default = ["secrets"]

diff --git a/crates/bitwarden/README.md b/crates/bitwarden/README.md
@@ -13,7 +13,7 @@ bitwarden = { "*", features = ["secrets"] }
 
 ## Minimum Supported Rust Version
 
-Rust **1.57** or higher.
+Rust **1.72** or higher.
 
 ## Example
 

diff --git a/crates/bw/Cargo.toml b/crates/bw/Cargo.toml
@@ -2,7 +2,7 @@
 name = "bw"
 version = "0.0.2"
 edition = "2021"
-rust-version = "1.60"
+rust-version = "1.72"
 authors = ["Bitwarden Inc"]
 license-file = "LICENSE"
 repository = "https://github.com/bitwarden/sdk"

diff --git a/crates/bws/Cargo.toml b/crates/bws/Cargo.toml
@@ -2,7 +2,7 @@
 name = "bws"
 version = "0.4.0"
 edition = "2021"
-rust-version = "1.60"
+rust-version = "1.72"
 authors = ["Bitwarden Inc"]
 license-file = "LICENSE"
 repository = "https://github.com/bitwarden/sdk"

diff --git a/crates/sdk-schemas/Cargo.toml b/crates/sdk-schemas/Cargo.toml
@@ -2,7 +2,7 @@
 name = "sdk-schemas"
 version = "0.1.0"
 edition = "2021"
-rust-version = "1.57"
+rust-version = "1.72"
 
 [features]
 internal = [

diff --git a/crates/uniffi-bindgen/Cargo.toml b/crates/uniffi-bindgen/Cargo.toml
@@ -2,7 +2,7 @@
 name = "uniffi-bindgen"
 version = "0.1.0"
 edition = "2021"
-rust-version = "1.57"
+rust-version = "1.72"
 
 [[bin]]
 # This can be whatever name makes sense for your project, but the rest of this tutorial assumes uniffi-bindgen.