Skip to content

Commit

Permalink
Remove unnecessary into() (#834)
Browse files Browse the repository at this point in the history
## ๐Ÿ“” Objective

Clippy was complaining in my local build that this into was unnecessary,
and for some reason this wasn't caught by CI

## โฐ Reminders before review

- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or
informed the documentation
  team

## ๐Ÿฆฎ Reviewer guidelines

<!-- Suggested interactions but feel free to use (or not) as you desire!
-->

- ๐Ÿ‘ (`:+1:`) or similar for great changes
- ๐Ÿ“ (`:memo:`) or โ„น๏ธ (`:information_source:`) for notes or general info
- โ“ (`:question:`) for questions
- ๐Ÿค” (`:thinking:`) or ๐Ÿ’ญ (`:thought_balloon:`) for more open inquiry
that's not quite a confirmed
  issue and could potentially benefit from discussion
- ๐ŸŽจ (`:art:`) for suggestions / improvements
- โŒ (`:x:`) or โš ๏ธ (`:warning:`) for more significant problems or
concerns needing attention
- ๐ŸŒฑ (`:seedling:`) or โ™ป๏ธ (`:recycle:`) for future improvements or
indications of technical debt
- โ› (`:pick:`) for minor or nitpick changes
  • Loading branch information
dani-garcia authored Jun 11, 2024
1 parent 3fc7fd2 commit 3f56e58
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/bitwarden-vault/src/cipher/linked_id.rs
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ impl TryFrom<u32> for LinkedIdType {
416 => Ok(LinkedIdType::Identity(IdentityLinkedIdType::FirstName)),
417 => Ok(LinkedIdType::Identity(IdentityLinkedIdType::LastName)),
418 => Ok(LinkedIdType::Identity(IdentityLinkedIdType::FullName)),
_ => Err(MissingFieldError("LinkedIdType").into()),
_ => Err(MissingFieldError("LinkedIdType")),
}
}
}
Expand Down

0 comments on commit 3f56e58

Please sign in to comment.