Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need to depend on js-sys when consuming errors #36

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Nov 22, 2024

🎟️ Tracking

📔 Objective

Switch from requiring consumers to depend on js-sys and let bitwarden-error crate re-expose it. Do we need to do the same thing for tsify?

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from coroiu November 22, 2024 08:35
Copy link
Contributor

github-actions bot commented Nov 22, 2024

Logo
Checkmarx One – Scan Summary & Detailsaba0e0ec-b6ca-4893-b588-ea66c2d970bd

No New Or Fixed Issues Found

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.34%. Comparing base (3cdf320) to head (b6c0a00).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   63.39%   63.34%   -0.05%     
==========================================
  Files         184      184              
  Lines       12935    12935              
==========================================
- Hits         8200     8194       -6     
- Misses       4735     4741       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go ahead and do the same for wasm-bindgen and tsify

@Hinton Hinton requested a review from coroiu November 25, 2024 10:48
@Hinton Hinton merged commit 130ac6f into main Nov 25, 2024
39 checks passed
@Hinton Hinton deleted the re-export-js-sys branch November 25, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants