Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore some stuff #344

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Ignore some stuff #344

merged 2 commits into from
Nov 14, 2024

Conversation

withinfocus
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

Internal change.

๐Ÿ“” Objective

Ignores output files and paths from directories used to test Actions.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@withinfocus withinfocus marked this pull request as ready for review November 14, 2024 14:55
@withinfocus withinfocus requested a review from a team as a code owner November 14, 2024 14:55
@withinfocus withinfocus merged commit 320efd5 into main Nov 14, 2024
5 checks passed
@withinfocus withinfocus deleted the ignores branch November 14, 2024 15:02
Copy link

github-actions bot commented Nov 14, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ b4bc2efe-6aa5-432e-8bef-2567b409320d

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants