Code

Refactor Workflow Linter#231

Code

Merged

joseph-flinn merged 60 commits intomainbitwarden/gh-actions:mainfrom feature/refactor-linterbitwarden/gh-actions:feature/refactor-linterCopy head branch name to clipboardMar 7, 2024

+4,940-3

Commits

Commits on Jan 26, 2023

• Refactoring the linter into an opinionated reformatter

  joseph-flinn

  committed
  cb14f1f

Commits on Apr 14, 2023

• Merge branch 'master' into feature/refactor-linter

  joseph-flinn

  committed
  ae9bfb2

Commits on Apr 21, 2023

• migrating how the rules are created for a more streamlined experience

  joseph-flinn

  committed
  cdc06a1

• removing the keyword from the step model since there are no linting tests run on it or any of it's children

  joseph-flinn

  committed
  704a5ed

Commits on May 5, 2023

• Switch from pydantic to dataclasses

  joseph-flinn

  committed
  4b36ac8

• Update to use the correct loader (Model.from_dict({})). Add extra data tests

  joseph-flinn

  committed
  1ef4a3b

• Got to a somewhat working breakdown of the rules (not including checking the actions)

  joseph-flinn

  committed
  87adafd

Commits on Dec 29, 2023

• Major additions, test writing, and rule import framework

  joseph-flinn

  committed
  691cc9f

• merge main and fix conflicts

  joseph-flinn

  committed
  9096b98

• update pip lockfile

  joseph-flinn

  committed
  42ad11a

Commits on Jan 3, 2024

• Build out the majority of the rules

  joseph-flinn

  committed
  34a4319

Commits on Jan 5, 2024

• Add sub commands to manage the list of approved actions

  joseph-flinn

  committed
  e7943e2

• Add test coverage and get test coverage of the rules to 100%

  joseph-flinn

  committed
  81cc449

• Update Python version in lint-ci to match refactored linter

  joseph-flinn

  committed
  8e4f866

• Removing old files. Update verbosity

  joseph-flinn

  committed
  e0a3ad8

Commits on Jan 9, 2024

• Finish in-code documentation

  joseph-flinn

  committed
  819ca78

• Run black over the code

  joseph-flinn

  committed
  060a33d

• Clean up the unused tests

  joseph-flinn

  committed
  33a9e74

• Expanded docs on how to add a new Rule

  joseph-flinn

  committed
  d35110c

Commits on Jan 10, 2024

• Remove old linter

  joseph-flinn

  committed
  1029baa

Commits on Jan 11, 2024

• First linting error fixes

  joseph-flinn

  committed
  0232bd5

• Fix all non-rule linter issues

  joseph-flinn

  committed
  3a233a5

• Switch to the cleaner json.load() function

  joseph-flinn

  committed
  a2930d8

• Fix unit tests

  joseph-flinn

  committed
  fc9cbf7

Commits on Jan 12, 2024

• Fix linting issues on job_environment_prefix

  joseph-flinn

  committed
  2131363

• Fix linting issues for RuleNameCapitalized

  joseph-flinn

  committed
  bdc35b8

• Fix linting warnings for RuleNameExists

  joseph-flinn

  committed
  9d91c1f

• Fix unit tests. Time to add some githooks...

  joseph-flinn

  committed
  527c41b

• Update with linter findings for RuleStepUsesApproved

  joseph-flinn

  committed
  b52eaab

• Remove 'message' attribute from Rule base class. Fix linting findings for RuleStepPinned

  joseph-flinn

  committed
  057c2c5

• Fix linter findings

  joseph-flinn

  committed
  40925be

• Finish linter finding cleanup

  joseph-flinn

  committed
  8ca7b95

• Reformat

  joseph-flinn

  committed
  5e4c980

• Fix type hinting

  joseph-flinn

  committed
  e49cde4

• Move lint-workflow to vs directory restore lint-workflow

  joseph-flinn

  committed
  4ca8b81

• Fix tests after type fixes. Add tests to CI

  joseph-flinn

  committed
  f263128

• Add new workflow path to the PR trigger

  joseph-flinn

  committed
  3e18bed

• Update trigger to all pull_request events instead of push events

  joseph-flinn

  committed
  17361c3

• Update workflow job names to be more helpful

  joseph-flinn

  committed
  f61921a

• Switch back to python 3.9 for v1 linter

  joseph-flinn

  committed
  8cf9043

Commits on Jan 13, 2024

• Fix edge case where 'env' doesn't exist in a job

  joseph-flinn

  committed
  d5b0f77

Commits on Jan 26, 2024

• Remove the end-to-end testing since it fails (as expected) and prevents a successful CI run

  joseph-flinn

  committed
  a957c84

• Working on packaging with Hatch

  joseph-flinn

  committed
  e133520

Commits on Feb 2, 2024

• Update to Nix Unstable packages to allow for editable paths

  joseph-flinn

  committed
  b8c0b8a

• Updating file structure. Tests passing

  joseph-flinn

  committed
  78d5561

• Got to installable and importable module

  joseph-flinn

  committed
  2d057f0

Commits on Feb 23, 2024

• Switch setting from a python file to a yaml file

  joseph-flinn

  committed
  9ddbb7a

• Update README with the new yaml settings

  joseph-flinn

  committed
  0880b30

• Debugging E2E tests. Need to handle creating the Jobs that don't have Steps (see test_a.yaml)

  joseph-flinn

  committed
  a8c70b9

• Save the latest vim session

  joseph-flinn

  committed
  17a8fc9

Commits on Feb 28, 2024

• Fixed the complex workflow loading

  joseph-flinn

  committed
  14e5ae1

• Update the JobRunnerVersionPinned rule to support callable workflows

  joseph-flinn

  committed
  2dc3cde

• Fix the lint command to be compatible with callable workflows

  joseph-flinn

  committed
  92a85c7

• Format code and fix type annotations

  joseph-flinn

  committed
  3f231e9

• Merge branch 'main' into feature/refactor-linter

  joseph-flinn

  committed
  db49c77

• Clean up of local opinionated development environment

  joseph-flinn

  committed
  86b9bd9

• Moving actions sub command to be in beta since we haven't decided to adopt that pattern

  joseph-flinn

  committed
  ed12be6

Commits on Feb 29, 2024

• Update all spelling errors identified and path issues (Thanks @vgrassia!)

  joseph-flinn

  committed
  1c0c8f3

• Add hacky safety measure to alert on GitHub Response Schema changes

  joseph-flinn

  committed
  e1951c7

Commits on Mar 6, 2024

• Fixed spelling issues

  joseph-flinn

  committed
  de9be6f