Fix the lint command to be compatible with callable workflows

bitwarden · Feb 28, 2024 · 92a85c7 · 92a85c7
1 parent 2dc3cde
commit 92a85c7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lint-workflow-v2/src/bitwarden_workflow_linter/lint.py b/lint-workflow-v2/src/bitwarden_workflow_linter/lint.py
@@ -104,9 +104,10 @@ def lint_file(self, filename: str) -> int:
             for rule in self.rules.job:
                 findings.append(rule.execute(job))
 
-            for step in job.steps:
-                for rule in self.rules.step:
-                    findings.append(rule.execute(step))
+            if job.steps is not None:
+                for step in job.steps:
+                    for rule in self.rules.step:
+                        findings.append(rule.execute(step))
 
         findings = list(filter(lambda a: a is not None, findings))
 

diff --git a/lint-workflow-v2/tests/rules/test_pinned_job_runner.py b/lint-workflow-v2/tests/rules/test_pinned_job_runner.py
@@ -59,6 +59,7 @@ def test_rule_on_correct_runner(rule, correct_runner):
     result, _ = rule.fn(correct_runner.jobs["call-workflow"])
     assert result is True
 
+
 def test_rule_on_incorrect_runner(rule, incorrect_runner):
     result, _ = rule.fn(incorrect_runner.jobs["job-key"])
     assert result is False