Skip to content

Commit

Permalink
exempt bitwarden/gh-actions from hash check
Browse files Browse the repository at this point in the history
  • Loading branch information
Eeebru committed Oct 24, 2023
1 parent c970b0f commit 269074d
Showing 1 changed file with 23 additions and 23 deletions.
46 changes: 23 additions & 23 deletions lint-workflow/lint.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,36 +292,36 @@ def lint(filename):
logging.info("Skipping local action in workflow.")
break

# If the step has a 'uses' key, check value hash.
try:

# Check to make sure SHA1 hash is 40 characters.
if len(hash) != 40:
findings.append(
LintFinding(
f"Step {str(i)} of job key '{job_key}' does not have a valid action hash. (not 40 characters)",
"error",
# If the step has a 'uses' key, check value hash, except bitwarden actions.
if "bitwarden/gh-actions" not in path:
try:
# Check to make sure SHA1 hash is 40 characters.
if len(hash) != 40:
findings.append(
LintFinding(
f"Step {str(i)} of job key '{job_key}' does not have a valid action hash. (not 40 characters)",
"error",
)
)
)

# Attempts to convert the hash to a integer
# which will succeed if all characters are hexadecimal
try:
int(hash, 16)
except ValueError:
# Attempts to convert the hash to a integer
# which will succeed if all characters are hexadecimal
try:
int(hash, 16)
except ValueError:
findings.append(
LintFinding(
f"Step {str(i)} of job key '{job_key}' does not have a valid action hash. (not all hexadecimal characters)",
"error",
)
)
except:
findings.append(
LintFinding(
f"Step {str(i)} of job key '{job_key}' does not have a valid action hash. (not all hexadecimal characters)",
f"Step {str(i)} of job key '{job_key}' does not have a valid action hash. (missing '@' character)",
"error",
)
)
except:
findings.append(
LintFinding(
f"Step {str(i)} of job key '{job_key}' does not have a valid action hash. (missing '@' character)",
"error",
)
)

# If the step has a 'uses' key, check path for external workflow
path_list = path.split("/", 2)
Expand Down

0 comments on commit 269074d

Please sign in to comment.