[PM-11873] Add Database Testing Instructions #480
Conversation
|
No New Or Fixed Issues Found |
|
Any guess as to why we didn't get a deployment? |
@withinfocus Maybe because the last commit is a month old? |
Deploying contributing-docs with
|
| Latest commit: |
5b13c27
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://60daf331.contributing-docs.pages.dev |
| Branch Preview URL: | https://database-testing.contributing-docs.pages.dev |
| @@ -0,0 +1,92 @@ | |||
| # Database Integration Testing | |||
|
|
|||
| Since Bitwarden has multiple database options (4), testing them all automatically is incredibly | |||
There was a problem hiding this comment.
🎨 I'd leave "4" out of this, as it could potentially change and this would be an easy miss.
There was a problem hiding this comment.
@addisonbeck also had some changes and improvements in #457, can these PRs be combined at all?
You would also be interested in his related changes to migrate.ps1 - I think this is fairly essential to devs being able to set up and tear down their local integration testing dbs.
I think those PRs are blocked on my feedback which suggested changing the structure of the keys in user secrets.
Co-authored-by: Matt Bishop <[email protected]>
Co-authored-by: Matt Bishop <[email protected]>
Yep! I haven't made it back around to these yet. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11873
📔 Objective
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes