Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR for usage of gRPC for networking between services #479

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cturnbull-bitwarden
Copy link

๐ŸŽŸ๏ธ Tracking

Originated out of https://bitwarden.atlassian.net/wiki/spaces/EN/pages/809828356/Proposal+The+Pricing+Plans+Service

๐Ÿ“” Objective

This PR introduces a new ADR titled "Adopting gRPC for Inter-Service Communication". The purpose is to document the decision-making process and outcomes regarding adopting gRPC for inter-service communication within Bitwarden's microservices architecture.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@cturnbull-bitwarden cturnbull-bitwarden requested a review from a team as a code owner November 20, 2024 19:07
@github-actions github-actions bot added the adr label Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ b6b15e7e-73aa-4173-94a5-bce3fcf5a59b

No New Or Fixed Issues Found

Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2024

Deploying contributing-docs with ย Cloudflare Pages ย Cloudflare Pages

Latest commit: 86940bc
Status:ย โœ…ย  Deploy successful!
Preview URL: https://0091685f.contributing-docs.pages.dev
Branch Preview URL: https://adr-24-grpc.contributing-docs.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant