[PM-7516] Restructure mobile docs for new native apps #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Deploying contributing-docs with
|
| Latest commit: |
ef3c6e7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cef61786.contributing-docs.pages.dev |
| Branch Preview URL: | https://mobiletf-pm-7516-mobile-rest.contributing-docs.pages.dev |
withinfocus
changed the title
withinfocus
requested changes
Aug 13, 2024
Comment on lines
14
to
19
| ## Compatibility | ||
|
|
||
| - **Minimum SDK**: 28 | ||
| - **Target SDK**: 34 | ||
| - **Device Types Supported**: Phone and Tablet | ||
| - **Orientations Supported**: Portrait and Landscape |
There was a problem hiding this comment.
🌱 This is likely to change somewhat frequently over time. The repos have a lot of this already too. Can we omit it here?
Co-authored-by: Matt Bishop <[email protected]>
Co-authored-by: Matt Bishop <[email protected]>
Co-authored-by: Matt Bishop <[email protected]>
Co-authored-by: Matt Bishop <[email protected]>
withinfocus
approved these changes
Aug 13, 2024
| [Git repository](https://github.com/bitwarden/mobile). | ||
| :::warning Legacy | ||
|
|
||
| This represents the **legacy** mobile app architecture done in .NET MAUI. |
There was a problem hiding this comment.
⛏️ "done" may be confusing to non-English speakers but this works well enough!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-7516
📔 Objective
Update the docs to include both the native app and the legacy .NET MAUI app.
Now the structure looks like:
Notes:
This PR only covers restructuring the folders. I'll open a new PR for the content of the new native docs, right now they only have a short description so the pages are not empty.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes