Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps]: Pin node to 20.15.0 - autoclosed #371

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 11, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
node (source) pin v20 -> 20.15.0

Add the preset :preserveSemverRanges to your config if you don't want to pin your dependencies.


Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner June 11, 2024 13:23
Copy link

cloudflare-workers-and-pages bot commented Jun 11, 2024

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a69a061
Status: ✅  Deploy successful!
Preview URL: https://07f6364b.contributing-docs.pages.dev
Branch Preview URL: https://renovate-pin-dependencies.contributing-docs.pages.dev

View logs

@bitwarden-bot
Copy link

bitwarden-bot commented Jun 11, 2024

Logo
Checkmarx One – Scan Summary & Details8dd6220a-7561-41e4-8a9d-7dbfa1f50bcc

No New Or Fixed Issues Found

@renovate renovate bot force-pushed the renovate/pin-dependencies branch 3 times, most recently from db04a94 to 33ec7ec Compare June 11, 2024 13:50
@Hinton
Copy link
Member

Hinton commented Jun 11, 2024

@jprusik this seems to be due to #370. I don't think we want to pin this, and we're fairly restrictive of when we bump the version in nvm and package.json.

@withinfocus
Copy link
Contributor

withinfocus commented Jun 11, 2024

@Hinton Jon and I were working together to roll this out anywhere NVM is used, and I called out that our pinning policy could conflict with it; our result was "eh, why not?" given the frequency this runs. The alternative is an overriding package rule e.g.:

{
  "matchManagers": ["nvm"],
  "rangeStrategy": "replace"
}

(untested) that we could try, but that's something to maintain on its own to me. I see this tracking with our normal rules of operation, and we can stay up on explicit Node installations locally.

@renovate renovate bot force-pushed the renovate/pin-dependencies branch from 33ec7ec to 7e006e1 Compare June 11, 2024 20:13
@Hinton
Copy link
Member

Hinton commented Jun 20, 2024

@Hinton Jon and I were working together to roll this out anywhere NVM is used, and I called out that our pinning policy could conflict with it; our result was "eh, why not?" given the frequency this runs. The alternative is an overriding package rule e.g.:

{
  "matchManagers": ["nvm"],
  "rangeStrategy": "replace"
}

(untested) that we could try, but that's something to maintain on its own to me. I see this tracking with our normal rules of operation, and we can stay up on explicit Node installations locally.

Fair, I guess I don't really like it since it's a bit of a maintenance burden little gain. We don't really have any tooling in place to enforce nvm is used and the ranges in package.json should be vague.

@renovate renovate bot changed the title [deps]: Pin node to 20.14.0 [deps]: Pin node to 20.15.0 Jun 20, 2024
@renovate renovate bot force-pushed the renovate/pin-dependencies branch 2 times, most recently from a14564b to 3c575b9 Compare June 24, 2024 13:59
@renovate renovate bot force-pushed the renovate/pin-dependencies branch from 3c575b9 to a69a061 Compare June 24, 2024 14:59
@renovate renovate bot changed the title [deps]: Pin node to 20.15.0 [deps]: Pin node to 20.15.0 - autoclosed Jun 25, 2024
@renovate renovate bot closed this Jun 25, 2024
@renovate renovate bot deleted the renovate/pin-dependencies branch June 25, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants