[PM-15506] Wire up vNextOrganizationService for libs/common and libs/angular #12683
+338
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com:bitwarden/clients into ac/pm-15506-Wire-up-vNext-OrganizationService
|
New Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## ac/pm-15506-vNextOrganizationService #12683 +/- ##
========================================================================
- Coverage 33.79% 33.71% -0.09%
========================================================================
Files 2911 2918 +7
Lines 90716 90997 +281
Branches 17154 17193 +39
========================================================================
+ Hits 30655 30676 +21
- Misses 57672 57928 +256
- Partials 2389 2393 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15506
📔 Objective
Partial implementation for wiring up vNextOrganizationService. This PR is organized by commits to make reviewing simpler for applicable teams. This PR will also include any services/components whose dependencies on the original OrganizationService would otherwise be broken by only updating the shared libs (this includes a few changes for all clients, mostly the CLI). The rest of the implementation will be spread out across their respective clients.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes