-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth/pm 7882/email verification removal #12670
Draft
Patrick-Pimentel-Bitwarden
wants to merge
13
commits into
main
Choose a base branch
from
auth/pm-7882/email-verification-removal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Auth/pm 7882/email verification removal #12670
Patrick-Pimentel-Bitwarden
wants to merge
13
commits into
main
from
auth/pm-7882/email-verification-removal
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of fixes and removal of the register route for signup in a lot of places.
No New Or Fixed Issues Found |
…on - More strict linting fixes.
…on - Fixed typo and one more form control.
…on - Updated function to use form control instead of function.
…on - Removed unnessesary function.
…on - Removed linting issues.
Patrick-Pimentel-Bitwarden
force-pushed
the
auth/pm-7882/email-verification-removal
branch
from
January 6, 2025 16:44
49cfc8f
to
4659f9a
Compare
…on - Removed ambiguous null value for params.
…on - Redid some logic for validate email.
…on - Ran prettier
…on - Made for accessors consistent.
…on - Fixed another toast converstion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-7326
📔 Objective
This pr is to remove the email verification removal feature flag.
Side objective is to fix the issues caused by enforcing strict linting.
Additional work:
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes