Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth/pm 7882/email verification removal #12670

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Patrick-Pimentel-Bitwarden
Copy link
Contributor

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden commented Jan 2, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-7326

📔 Objective

This pr is to remove the email verification removal feature flag.

Side objective is to fix the issues caused by enforcing strict linting.

Additional work:

  • Fixed typos for i18n strings
  • Switched off platformUtilService.showToast to correct toastService.showToast
  • Allowed for nullish toast titles as it seems we do that around the code base
  • Documented the toast service show toast function to clarify how the show toast parameters works
    • Removed custom timeouts on toasts because there was no documentation around why there was a custom provided time.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Logo
Checkmarx One – Scan Summary & Details6af2b627-5cbf-458c-a0d5-ea2256952310

No New Or Fixed Issues Found

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden force-pushed the auth/pm-7882/email-verification-removal branch from 49cfc8f to 4659f9a Compare January 6, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant