Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16675] Prevent scrollbar from appearing on each send item #12666

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Jan 2, 2025

🎟️ Tracking

PM-16675

📔 Objective

On the Send page, items were rendering with individual scrollbars. This was due to a misplaced padding override on the send items causing it to be shorter than expected, and a previous change to increase the click area of item action buttons causing the buttons to overflow the short item container. This PR fixes the send item padding and hides overflow on items.

📸 Screenshots

Before:

Screen.Recording.2025-01-02.at.4.38.16.PM.mov

After:

Screen.Recording.2025-01-02.at.4.40.58.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Logo
Checkmarx One – Scan Summary & Details73f14efe-8456-447d-9545-0868a7c168d2

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.73%. Comparing base (af4311f) to head (3874bb0).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12666      +/-   ##
==========================================
- Coverage   33.74%   33.73%   -0.02%     
==========================================
  Files        2918     2918              
  Lines       90911    90929      +18     
  Branches    17180    17185       +5     
==========================================
- Hits        30677    30672       -5     
- Misses      57841    57864      +23     
  Partials     2393     2393              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vleague2 vleague2 marked this pull request as ready for review January 2, 2025 21:54
@vleague2 vleague2 requested review from a team as code owners January 2, 2025 21:54
@vleague2 vleague2 requested review from merissaacosta and willmartian and removed request for merissaacosta January 2, 2025 21:54
Copy link
Member

@audreyality audreyality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Looks like this fixes a layout bug on the send item view, too!

@vleague2 vleague2 merged commit c074543 into main Jan 3, 2025
89 checks passed
@vleague2 vleague2 deleted the uif/pm-16675/send-item-padding branch January 3, 2025 14:41
vleague2 added a commit that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants