Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14567] - fix routes. update copy and headers #11908

Merged
merged 5 commits into from
Nov 14, 2024
Merged

[PM-14567] - fix routes. update copy and headers #11908

merged 5 commits into from
Nov 14, 2024

Conversation

jaasen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14557

📔 Objective

This PR updates the access-intelligence routing and navigation to match design. It also updates some of the copy and adds logic for hiding the "Last updated" if there are no apps to check.

📸 Screenshots

Screenshot 2024-11-06 at 11 44 43 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 33.48%. Comparing base (251213b) to head (20e3f7b).
Report is 17 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../access-intelligence/access-intelligence.module.ts 0.00% 4 Missing ⚠️
...nizations/layouts/organization-layout.component.ts 0.00% 2 Missing ⚠️
...nsole/organizations/organization-routing.module.ts 0.00% 2 Missing ⚠️
...intelligence/access-intelligence-routing.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11908   +/-   ##
=======================================
  Coverage   33.48%   33.48%           
=======================================
  Files        2844     2844           
  Lines       89023    89023           
  Branches    16980    16980           
=======================================
  Hits        29807    29807           
  Misses      56873    56873           
  Partials     2343     2343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

>
<bit-nav-item
[text]="'riskInsights' | i18n"
route="access-intelligence/risk-insights"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This does not match the existing route and would route to an non existing page.

Copy link
Collaborator Author

@jaasen-livefront jaasen-livefront Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaasen-livefront jaasen-livefront changed the title [PM_14567] - fix routes. update copy and headers [PM-14567] - fix routes. update copy and headers Nov 7, 2024
djsmith85
djsmith85 previously approved these changes Nov 7, 2024
ttalty
ttalty previously approved these changes Nov 11, 2024

This comment was marked as off-topic.

@merissaacosta merissaacosta requested review from willmartian and shane-melton and removed request for merissaacosta November 13, 2024 14:43
@willmartian
Copy link
Contributor

I removed the extra reviewers that were (to my knowledge) tagged unintentionally. If I removed anyone that actually needs to review this, please add them back. :)

ttalty
ttalty previously approved these changes Nov 13, 2024
@ttalty ttalty merged commit b0c5b5e into main Nov 14, 2024
37 checks passed
@ttalty ttalty deleted the PM-14567 branch November 14, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants