-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14567] - fix routes. update copy and headers #11908
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11908 +/- ##
=======================================
Coverage 33.48% 33.48%
=======================================
Files 2844 2844
Lines 89023 89023
Branches 16980 16980
=======================================
Hits 29807 29807
Misses 56873 56873
Partials 2343 2343 ☔ View full report in Codecov by Sentry. |
> | ||
<bit-nav-item | ||
[text]="'riskInsights' | i18n" | ||
route="access-intelligence/risk-insights" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djsmith85 This PR also updates the route to reflect these changes.
access-intelligence
- https://github.com/bitwarden/clients/pull/11908/files#diff-68379c0fec3ef65ee2e9916d3d4234c0ff0298cb0b7fec389e1c87c8513debe5R66
risk-insights
- https://github.com/bitwarden/clients/pull/11908/files#diff-c6135b030fa024cbafb87c5c742698b44951a5e2fff7c9a6f42a59c34c96a9d2
9a3b83c
to
4d3716d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
I removed the extra reviewers that were (to my knowledge) tagged unintentionally. If I removed anyone that actually needs to review this, please add them back. :) |
This reverts commit 4d3716d.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14557
📔 Objective
This PR updates the access-intelligence routing and navigation to match design. It also updates some of the copy and adds logic for hiding the "Last updated" if there are no apps to check.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes