Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-000 | turn pre-release flag on for browser refresh beta build #11868

Closed
wants to merge 167 commits into from

Conversation

merissaacosta
Copy link
Contributor

📔 Objective

To create a beta build for the extension refresh release, we need to turn the prereleaseBuild flag on.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

vleague2 and others added 30 commits April 10, 2024 15:24
* update typography docs, story, color

* add SM Sans font, remove Open Sans

---------

Co-authored-by: Oscar Hinton <[email protected]>
* update callout styles; make component standalone

* add import block to mdx page
* update styles and add card story

* update docs

* add important to typography styles

* [CL-239] simple dialog style refresh

* [CL-342] fix text overflow in dialog; add story

* use main color for headers

* update loading styles: spinner height and alt text; body min height

* update simple dialog border radius

* add badge to story
* add readonly styles

* update label styles; update stories

* code review changes
trmartin4
trmartin4 previously approved these changes Nov 5, 2024
@willmartian
Copy link
Contributor

Closing since we aligned on create beta builds from a separate branch.

@willmartian willmartian closed this Nov 6, 2024
@merissaacosta merissaacosta reopened this Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Logo
Checkmarx One – Scan Summary & Detailsdba1eb1a-5d21-4809-b5a4-87237e4d1708

Fixed Issues

Severity Issue Source File / Package
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/web/src/app/auth/trial-initiation/trial-initiation.component.html: 100
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/web/src/app/auth/trial-initiation/trial-initiation.component.html: 97
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/web/src/app/auth/trial-initiation/secrets-manager/secrets-manager-trial-paid-stepper.component.html: 43
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/web/src/app/auth/trial-initiation/secrets-manager/secrets-manager-trial-paid-stepper.component.html: 31
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/web/src/app/auth/trial-initiation/secrets-manager/secrets-manager-trial-paid-stepper.component.html: 20
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 876

Base automatically changed from ps/extension-refresh to main November 15, 2024 14:21
@willmartian willmartian dismissed trmartin4’s stale review November 15, 2024 14:21

The base branch was changed.

@willmartian willmartian requested review from a team as code owners November 15, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants