-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-000 | turn pre-release flag on for browser refresh beta build #11868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update typography docs, story, color * add SM Sans font, remove Open Sans --------- Co-authored-by: Oscar Hinton <[email protected]>
Co-authored-by: Will Martin <[email protected]>
* update callout styles; make component standalone * add import block to mdx page
* update styles and add card story * update docs * add important to typography styles * [CL-239] simple dialog style refresh * [CL-342] fix text overflow in dialog; add story * use main color for headers * update loading styles: spinner height and alt text; body min height * update simple dialog border radius * add badge to story
* add readonly styles * update label styles; update stories * code review changes
trmartin4
previously approved these changes
Nov 5, 2024
Closing since we aligned on create beta builds from a separate branch. |
Fixed Issues
|
willmartian
requested review from
r-tome,
shane-melton and
Patrick-Pimentel-Bitwarden
November 15, 2024 14:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Objective
To create a beta build for the extension refresh release, we need to turn the
prereleaseBuild
flag on.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes