Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11764] Implement account switching and sdk initialization #11472
[PM-11764] Implement account switching and sdk initialization #11472
Changes from 8 commits
657d2f2
e332670
f7f79ba
f4a589f
d7e82fc
cc8302a
421f372
f95cfe5
8e0ef47
7e7a10a
1ed18e5
e8a1049
b9a729b
ac89518
3adc18e
6b7b016
85d4809
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 95 in libs/common/src/platform/services/sdk/default-sdk.service.ts
GitHub Actions / Chromatic
Check failure on line 113 in libs/common/src/platform/services/sdk/default-sdk.service.ts
GitHub Actions / Chromatic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: I'm not 100% happy with this, but I can't really see any better solutions short-of removing the cache all together or maybe writing some advanced separate utility for it. Caching is hard.
An alternative would be to remove this and let the cache grow (leak memory). I don't think it would ever be an issue since nobody logs in and out of so many accounts that it will actually become an issue, but @JaredSnider-Bitwarden challenged me on this approach and in the end I leaned towards not leaking.