Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11764] Implement account switching and sdk initialization #11472

Merged
merged 17 commits into from
Oct 18, 2024

fix: broken impl and race condition in tests

85d4809
Select commit
Loading
Failed to load commit list.
Merged

[PM-11764] Implement account switching and sdk initialization #11472

fix: broken impl and race condition in tests
85d4809
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 16, 2024 in 0s

33.19% (-0.01%) compared to 36c965c, passed because coverage increased by 0% when compared to adjusted base (33.19%)

View this Pull Request on Codecov

33.19% (-0.01%) compared to 36c965c, passed because coverage increased by 0% when compared to adjusted base (33.19%)

Details

Codecov Report

Attention: Patch coverage is 77.77778% with 10 lines in your changes missing coverage. Please review.

Project coverage is 33.19%. Comparing base (36c965c) to head (85d4809).
Report is 45 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...n/src/platform/services/sdk/default-sdk.service.ts 82.92% 4 Missing and 3 partials ⚠️
...ibs/common/src/platform/services/crypto.service.ts 0.00% 2 Missing ⚠️
...ibs/common/src/auth/services/kdf-config.service.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11472      +/-   ##
==========================================
- Coverage   33.19%   33.19%   -0.01%     
==========================================
  Files        2772     2779       +7     
  Lines       86137    86362     +225     
  Branches    16411    16452      +41     
==========================================
+ Hits        28594    28666      +72     
- Misses      55278    55419     +141     
- Partials     2265     2277      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov