fix consistency with uncertain cases in isCardExpired

bitwarden · Jan 2, 2025 · 85c2b1d · 85c2b1d
1 parent 5bf2e4d
commit 85c2b1d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/libs/common/src/autofill/utils.spec.ts b/libs/common/src/autofill/utils.spec.ts
@@ -93,7 +93,7 @@ function getCardExpiryDateValues() {
     [undefined, undefined, false], // no month, no year, invalid values
     ["", "", false], // no month, no year, invalid values
     ["12", "agdredg42grg35grrr. ea3534@#^145345ag$%^  -_#$rdg ", false], // invalid values
-    ["0", `${currentYear}`, true], // invalid month
+    ["0", `${currentYear}`, false], // invalid month
     ["0", `${currentYear - 1}`, true], // invalid 0 month
     ["00", `${currentYear + 1}`, false], // invalid 0 month
     [`${currentMonth}`, "0000", true], // current month, in the year 2000

diff --git a/libs/common/src/autofill/utils.ts b/libs/common/src/autofill/utils.ts
@@ -51,7 +51,7 @@ export function normalizeExpiryYearFormat(yearInput: string | number): Year | nu
 
 /**
  * Takes a cipher card view and returns "true" if the month and year affirmativey indicate
- * the card is expired. Uncertain cases return "false"
+ * the card is expired. Uncertain cases return "false".
  *
  * @param {CardView} cipherCard
  * @return {*}  {boolean}
@@ -85,9 +85,9 @@ export function isCardExpired(cipherCard: CardView): boolean {
       const parsedMonthInteger = parseInt(expMonth, 10);
       const parsedMonthIsValid = parsedMonthInteger && !isNaN(parsedMonthInteger);
 
-      // If the parsed month value is 0, we don't know when the expiry passes this year, so treat it as expired
+      // If the parsed month value is 0, we don't know when the expiry passes this year, so do not treat it as expired
       if (!parsedMonthIsValid) {
-        return true;
+        return false;
       }
 
       // `Date` months are zero-indexed