-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove query after patch #256
Conversation
📝 WalkthroughWalkthroughThe changes involve modifying the Changes
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/upgrades/v020/upgrades.go (1)
119-124
: Consider fully removing the commented-out code.
Leaving large commented blocks can create confusion. If you're certain you no longer need this delegated reward calculation, removing it altogether will simplify the code.Here's a suggested diff to remove these lines:
- // for _, del := range k.StakingKeeper.GetAllDelegations(ctx) { - // valAddr := del.GetValidatorAddr() - // val := k.StakingKeeper.Validator(ctx, valAddr) - // // calculate rewards - // k.DistrKeeper.CalculateDelegationRewards(ctx, val, del, uint64(ctx.BlockHeight())) - // }
remove unnecessary query
Summary by CodeRabbit